justinpakzad commented on PR #74922: URL: https://github.com/apache/airflow/pull/74922#issuecomment-6278762590
> Thanks for the PR. Look good overall! Non-blocking: could we also assert that the fixed offset itself survives the datetime round-trip? > > `test_datetime` currently compares only `timestamp()`, so a value restored as `07:00+00:00` would still pass for an original `09:00+02:00`. An assertion such as the following would make the intended guarantee explicit: Yep! Good call. The `else` branch actually never even ran here because they all matched the first `isinstance` so the `.timestamp()` comparison never happened. I've updated the test to check to include `utcoffset()` for datetimes and `==` for everything else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
