dheerajturaga opened a new pull request, #75157:
URL: https://github.com/apache/airflow/pull/75157

   ### Stack
   
   Stacks on #75156. Stack index: 9 of 20.
   
   Its base is the branch of #75156, so the diff shows only this layer's 
commit, "AIP-125: Add inbound webhook sources to the standard provider".
   
   ### Status
   
   Draft. [AIP-125 (Inbound 
Webhooks)](https://lists.apache.org/thread/p3dpnor4zwko8tldpncj6ftj1bpp18q7) is 
under discussion on dev@ and not yet voted; this stack is its proof of concept 
so that voters can run it, and nothing should merge before the vote. The 
feature is opt-in (only `airflow api-server --apps webhooks` serves deliveries) 
and experimental; no unauthenticated route is reachable until stack PR 18, 
which merges last.
   
   ### Why
   
   Services without a provider of their own still need their deliveries 
verified, so `hmac_json` and `token_header` are configured entirely from the 
webhook connection's extra, where fields left empty in the connection form 
count as unset. They keep the proof of concept's paths and kinds, so subscribed 
Dags keep their names, and the base-class import is guarded because the 
provider still supports cores without inbound webhooks.
   
   ### What to look at
   
   - `InboundWebhookHook` registers the `inbound_webhook` connection type and 
its form fields.
   - The extra's option names (`signature_header`, `token_header`, 
`event_field`, `delivery_id_header` and others), and empty fields counting as 
unset.
   - Headers are not signed, so the docs recommend body fields over 
`event_header` and `delivery_id_header`.
   - The form's `store_payload` field takes effect with stack PR 15.
   - `get_provider_info.py` is regenerated by `update-providers-build-files`. 
No changelog edit, as provider changelogs are written from git log at release.
   
   ### Testing
   
   - `test_generic.py` and `test_inbound_webhook.py` (44 tests) passed under 
breeze on SQLite, Postgres and MySQL. mypy under breeze reports no issues. 
After the last fixes, the tests were rerun on SQLite and Postgres, and the 
final head passed again on MySQL.
   - `breeze build-docs` is clean for the standard provider.
   
   ### Known limitations
   
   - The tests port only the proof of concept's synthetic cases; golden 
fixtures from recorded, redacted deliveries wait for its 0.2 release.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 5.5)
   
   Generated-by: Claude Code (Opus 5.5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to