dheerajturaga opened a new pull request, #75165:
URL: https://github.com/apache/airflow/pull/75165

   ### Stack
   
   Stacks on #75164. Stack index: 17 of 20.
   
   Its base is the branch of #75164, so the diff shows only this layer's 
commit, "AIP-125: Show the webhook source on asset events".
   
   ### Status
   
   Draft. [AIP-125 (Inbound 
Webhooks)](https://lists.apache.org/thread/p3dpnor4zwko8tldpncj6ftj1bpp18q7) is 
under discussion on dev@ and not yet voted; this stack is its proof of concept 
so that voters can run it, and nothing should merge before the vote. The 
feature is opt-in (only `airflow api-server --apps webhooks` serves deliveries) 
and experimental; no unauthenticated route is reachable until stack PR 18, 
which merges last.
   
   ### Why
   
   An asset event recorded for a webhook delivery has no source task, so the 
asset event list showed no source for it. It is now labelled Webhook, like API 
and Trigger (now translated too), and links to its delivery, whose row on the 
deliveries page now also shows the names it offered and the events it recorded.
   
   ### What to look at
   
   - A change for every asset event: a source task now wins over the 
`from_rest_api`, `from_trigger` and `from_webhook` flags, because any task can 
set them in its outlet events' extra. Before, the API and trigger flags won 
over the task.
   - A flag that is not shown as the source stays visible in the rendered extra.
   - The delivery link is built only when `webhook` matches the name grammar 
and `inbound_delivery_id` is a string.
   
   ### Testing
   
   - New cases in `AssetEvent.test.tsx` and `WebhookDeliveries.test.tsx`; the 
vitest suites passed on the host. The last change to this commit, one column 
label, came after that run, and no test reads it.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 5.5)
   
   Generated-by: Claude Code (Opus 5.5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to