AlejandroMorgante commented on code in PR #74386: URL: https://github.com/apache/airflow/pull/74386#discussion_r4320433955
########## providers/databricks/src/airflow/providers/databricks/operators/agent.py: ########## @@ -0,0 +1,200 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Operators for invoking Databricks agents.""" + +from __future__ import annotations + +import json +import time +from collections.abc import Sequence +from datetime import timedelta +from functools import cached_property +from typing import TYPE_CHECKING, Any +from uuid import NAMESPACE_URL, UUID, uuid5 + +from airflow.providers.common.compat.sdk import AirflowFailException, BaseOperator, conf +from airflow.providers.databricks.exceptions import ( + DatabricksAgentInvocationError, + DatabricksAgentInvocationTimeout, +) +from airflow.providers.databricks.hooks.agent import DatabricksAgentHook +from airflow.providers.databricks.triggers.agent import DatabricksAgentInvocationTrigger + +if TYPE_CHECKING: + from airflow.providers.common.compat.sdk import Context + + +class DatabricksAgentInvokeOperator(BaseOperator): + """ + Invoke a DurableAgentServer on Databricks Apps and optionally wait for its result. + + :param app_url: HTTPS base URL of the deployed app. (templated) + :param input: JSON-serializable agent input. (templated) + :param databricks_conn_id: Databricks connection using service principal OAuth. + Defaults to ``databricks_default``. (templated) + :param session_id: Conversation ID. CLI template agents require this field. + Defaults to ``None``. (templated) + :param invocation_id: Idempotency UUID. Defaults to a stable UUID for this task instance, + app URL, input and session, shared across retries and clears with unchanged input and session. + A stored failure requires a new UUID to run again. (templated) + :param wait_for_termination: Wait for completion or interruption. If false, return the submission response. + Defaults to ``True``. + :param polling_period_seconds: Seconds between status checks. Defaults to ``10``. + :param timeout: Maximum seconds to wait after submission. Timing out does not cancel the remote invocation. + Defaults to ``3600``. + :param deferrable: Release the worker while waiting. Defaults to ``[operators] default_deferrable``, + with a fallback of ``False``. + """ + + template_fields: Sequence[str] = ("app_url", "input", "databricks_conn_id", "session_id", "invocation_id") + template_fields_renderers = {"input": "json"} + ui_color = "#1CB1C2" + ui_fgcolor = "#fff" + + def __init__( + self, + *, + app_url: str, + input: Any, + databricks_conn_id: str = "databricks_default", + session_id: str | None = None, + invocation_id: str | None = None, + wait_for_termination: bool = True, + polling_period_seconds: float = 10, + timeout: float = 3600, + deferrable: bool = conf.getboolean("operators", "default_deferrable", fallback=False), + **kwargs, + ) -> None: + super().__init__(**kwargs) + if polling_period_seconds <= 0 or timeout <= 0: + raise ValueError("polling_period_seconds and timeout must be positive") + self.app_url = app_url + self.input = input + self.databricks_conn_id = databricks_conn_id + self.session_id = session_id + self.invocation_id = invocation_id + self.wait_for_termination = wait_for_termination + self.polling_period_seconds = polling_period_seconds + self.timeout = timeout + self.deferrable = deferrable + + @cached_property + def hook(self) -> DatabricksAgentHook: + return DatabricksAgentHook(self.app_url, self.databricks_conn_id) + + def _get_invocation_id(self, context: Context) -> str: + if self.invocation_id is not None: + return str(UUID(self.invocation_id)) + ti = context["ti"] + identity = json.dumps( + [ + self.app_url.rstrip("/"), + ti.dag_id, + ti.task_id, + ti.run_id, + ti.map_index, + self.input, + self.session_id, + ], + sort_keys=True, + ) + return str(uuid5(NAMESPACE_URL, identity)) + + def _get_result(self, result: dict[str, Any], invocation_id: str) -> dict[str, Any] | None: + status = result.get("status") + if status == "failed": + raise AirflowFailException( + f"Databricks agent invocation {invocation_id} failed; inspect the app logs " + "and supply a new invocation_id to run again" + ) + if status == "completed": + self.log.info("Databricks agent invocation %s completed.", invocation_id) + return result + if not status: + raise DatabricksAgentInvocationError( + f"Databricks agent invocation {invocation_id} response is missing its status" + ) + return None + + def execute(self, context: Context) -> dict[str, Any]: + invocation_id = self._get_invocation_id(context) + self.log.info("Submitting Databricks agent invocation %s.", invocation_id) + submitted = self.hook.create_invocation(invocation_id, self.input, self.session_id) + self.log.info("Databricks agent invocation %s was submitted.", invocation_id) + if not self.wait_for_termination: + return submitted Review Comment: Done, moved the failed-status check before the early return and added a regression test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
