Adityakk9031 commented on PR #69504:
URL: https://github.com/apache/airflow/pull/69504#issuecomment-6287458835

   Hey @ashb, thanks for the earlier review. I've replied on both threads: 
switched to `import_string` as you suggested (88768c0), and `dsn` is still 
popped so `sentry_sdk.init(dsn=..., **opts)` doesn't hit a duplicate-argument 
`TypeError`.
   
   @potiuk's point about `conf.getimport` going through secrets backends and 
env overrides is worth a quick look from your side too. Happy to go either way 
if you prefer that.
   
   Could you take another look when you get a chance? Also, just so it's 
visible: this is the actual fix for #69464, which got auto-closed by #73679 by 
mistake. Thanks!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to