kacpermuda commented on code in PR #75132:
URL: https://github.com/apache/airflow/pull/75132#discussion_r4335179774
##########
task-sdk/src/airflow/sdk/execution_time/schema/schema.json:
##########
@@ -3266,14 +3266,51 @@
"terminal_is_mapped": {
"title": "Terminal Is Mapped",
"type": "boolean"
+ },
+ "region_id": {
+ "format": "uuid",
+ "title": "Region Id",
+ "type": "string"
+ },
+ "trajectory": {
+ "minimum": 1,
+ "title": "Trajectory",
+ "type": "integer"
+ },
+ "forked_from_region_id": {
+ "anyOf": [
Review Comment:
I went with “sent, or absent” for the new fields, using the same pattern as
RegionId/RegionIndex. I did try post-processing the supervisor schema globally,
but it doesn’t fit in this PR:
- replacing anyOf with oneOf, as the FastAPI app does, makes go-jsonschema
emit interface{} for about 20 fields that are typed pointers today;
- collapsing nullable optional fields to “sent or absent” retypes around 80
Go fields and breaks the Go SDK build (pkg/execution, pkg/binding).
So I’d suggest doing the global fix separately, together with the Go/TS SDK
side. Happy to open an issue for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
