ephraimbuddy commented on code in PR #71459:
URL: https://github.com/apache/airflow/pull/71459#discussion_r4339919874


##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py:
##########
@@ -247,6 +238,7 @@ def patch_dag_run(
     if not final_dag_run:
         raise HTTPException(status.HTTP_404_NOT_FOUND, "Dag run not found 
after update")
 
+    attach_dag_versions_to_runs([final_dag_run], session=session)

Review Comment:
   `clear_dag_run` and `clear_dag_runs` still return the run from 
`perform_clear_dag_run` without this. That’s the flow from the issue: clearing 
a large pinned run now loads every current and archived attempt to build 
`dag_versions`, and the bulk route does it once per `run. trigger_dag_run` and 
`materialize_asset` take the same path, though it’s cheap there because the run 
is new. Rather than adding one more route, could the DISTINCT lookup move into 
the property fallback so new routes can’t miss it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to