henry3260 commented on code in PR #73119:
URL: https://github.com/apache/airflow/pull/73119#discussion_r4348932258
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/assets.py:
##########
@@ -715,17 +801,27 @@ def delete_asset_queued_events(
readable_dags_filter: ReadableDagsFilterDep,
session: SessionDep,
before: OptionalDateTimeQuery = None,
+ partition_key: QueuedEventPartitionKeyQuery = None,
):
"""Delete queued asset events for an asset."""
- where_clause = _generate_queued_event_where_clause(
- asset_id=asset_id, before=before,
permitted_dag_ids=readable_dags_filter.value
- )
- delete_stmt = delete(AssetDagRunQueue).where(*where_clause)
- result = cast("CursorResult", session.execute(delete_stmt))
- if result.rowcount == 0:
+ if partition_key is not None:
+ deleted = _delete_pending_partitioned_queued_events(
+ partition_key=partition_key,
+ asset_id=asset_id,
+ before=before,
+ permitted_dag_ids=readable_dags_filter.value,
Review Comment:
Rebased, and the partition path now passes `editable_dags_filter.value` too,
so both
branches of the route enforce the same Dag axis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
