kadubhumika commented on code in PR #74916:
URL: https://github.com/apache/airflow/pull/74916#discussion_r4352401974


##########
airflow-core/src/airflow/serialization/serialized_objects.py:
##########
@@ -1222,6 +1222,8 @@ def populate_operator(
                 v = cls.deserialize(v)
             elif k == "_on_failure_fail_dagrun":
                 k = "on_failure_fail_dagrun"
+            elif k == "_on_success_succeed_dagrun":
+                k = "on_success_succeed_dagrun"

Review Comment:
   @FrankYang0529 Thanks for pointing this out. The mapped operator stores 
`on_success_succeed_dagrun` in `partial_kwargs`, so I removed the redundant 
`_on_success_succeed_dagrun` rename branch and left the existing failure-flag 
handling unchanged. I also extended `test_teardown_mapped_serialization` to 
verify that `on_success_succeed_dagrun=False` is preserved through 
serialization and deserialization. The targeted test passes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to