zach-overflow commented on code in PR #74726:
URL: https://github.com/apache/airflow/pull/74726#discussion_r4352575715
##########
task-sdk/src/airflow/sdk/execution_time/comms.py:
##########
@@ -849,8 +849,15 @@ def from_api_response(cls, dag_response: DagResponse) ->
DagResult:
return cls(**dag_response.model_dump(exclude_defaults=True),
type="DagResult")
+class AssetEventEmissionResult(BaseModel):
Review Comment:
Mainly reiterating my thoughts from the devlist email: I think the broad
usefulness of the feature you're proposing should be its own distinct class and
Airflow concept. In other words, I wouldn't tie this to just assets. Personal
preference would be to not have "Asset" in the name either, since that again
somewhat downplays the applicability of the feature here.
Maybe this new feature/concept could be called an "Emitter"? "Signal"?
Naming is always hard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
