DrFaust92 commented on PR #73016: URL: https://github.com/apache/airflow/pull/73016#issuecomment-6356458037
Rebased onto current `main` — the branch was 1358 commits behind, now 0. Clean rebase, no conflicts, and I checked that none of those commits added a new `checksum/*` annotation using the old whole-manifest form (the only `sha256sum` left in `chart/templates` is inside the helper). Also added the two things this PR was missing: **Newsfragment** — `chart/newsfragments/73016.bugfix.rst`. **A regression test** — `chart/tests/helm_tests/airflow_aux/test_config_checksums.py`, pinning the contract in both directions: - A label added through the `labels` value must not move any checksum. That label lands in the same `metadata.labels` block as `chart: "airflow-2.0.0"`, so it stands in for the chart version, which isn't settable through values. - `checksum/airflow-config` must still move on a real config change (`config.core.parallelism`). I verified it's a real guard rather than assuming. Reverting the fix in one deployment fails the first assertion, and the mechanism is visible directly: ``` with the fix: base da95149d… +label da95149d… (unchanged) without the fix: base 93d378bc… +label f6effe24… (moves) ``` One thing worth recording for anyone verifying this by hand: `jwtSecret` and the metadata connection password are generated when not supplied, so two renders of the same chart differ for reasons unrelated to this change. The test pins both. With them pinned, all 10 `checksum/*` annotations are stable across a chart version bump. `helm_tests/airflow_aux` passes in full: **793 tests**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
