kadubhumika commented on PR #74330: URL: https://github.com/apache/airflow/pull/74330#issuecomment-6366227881
Thanks @jroachgolf84 for the review. I’ve pushed the changes: Warning message: reworded in all three operators (DatabricksSubmitRunOperator, DatabricksRunNowOperator, DatabricksSQLStatementsOperator) as suggested. It now reads: “outlets are set with wait_for_termination=False. This means that an Asset event will be emitted when the Databricks run is submitted, not when the table is refreshed.” The SQL operator says “SQL statement” instead of “Databricks run”. Docs: removed the “does not infer which tables...” sentence from sql_statements.rst, run_now.rst and submit_run.rst. The intro now just says how to declare outlets with UnityTableIdentity. Tests: updated the expected warning text in the three test_outlets_warn_when_not_waiting tests. The earlier CI failure (TestDatabricksSQLStatementsOperator::test_outlets_warn_when_not_waiting) was my mistake: the expected string said “Databricks run” instead of “SQL statement”. That is fixed now, and the 9 outlets tests pass locally. Please take another look when you have time. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
