kaxil opened a new pull request, #1701:
URL: https://github.com/apache/airflow-site/pull/1701
On the Airflow docs, the right-hand "On this page" list is pinned 263px from
the top of the window, while the content and the left sidebar sit just under
the 90px navbar. When you scroll, the left sidebar sticks at 90px and the
right-hand list stays at 263px.
The 263px comes from `.roadmap .wy-nav-side-toc { top: 263px !important; }`
in `_community-page.scss`, added for the community page's side TOC in #1062.
The Sphinx docs layout also uses `.roadmap`, so the rule overrides the docs'
own `top: $fixed-header-offset-desktop` (90px) from `_roadmap.scss`. This
scopes it to the community page as `.desktop-only > .roadmap .wy-nav-side-toc`.
The community page is the only layout that puts `.roadmap` inside
`.desktop-only`, and the only Hugo layout with a side TOC, so it keeps its
263px.
| Measured at 1728px wide | Now | With this PR and apache/airflow's
custom.css fix |
|---|---|---|
| Content / left sidebar / right list start at | 253 / 253 / 263px | 130 /
130 / 130px |
| Left sidebar / right list stick at while scrolling | 90 / 263px | 90 /
90px |
The 253px start is a separate stale offset in Airflow's own `custom.css`,
fixed in a companion apache/airflow PR. On the live community page, swapping in
the scoped rule leaves its side TOC at 263px; on a live docs page the docs fall
back to 90px.
Only SCSS changes here, which the version hook does not hash, so this bumps
the theme to 0.3.16 by hand, as #1523 did, so the build publishes it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
