Andrushika commented on PR #75387: URL: https://github.com/apache/airflow/pull/75387#issuecomment-6368118590
Agree with Jason, and sorry for my incorrect suggestion in #74869. I think we can keep this PR to only "undo" the changes on the Python Task SDK path. Maybe we should also rename `StartExecutionTimeout` back to `SetExecutionTimeout`, since it carries the timeout again. That name was approved in #73806 and already shipped in 3.4.0b1 and b2. One thing we may need to document: with Jason's approach, Python tasks and language SDK tasks read `[core] default_task_execution_timeout` from different places. For a task that does not set `execution_timeout` itself: | Config set on | Python task | Language SDK task | |---|---|---| | Dag processor only (A) | no timeout | A | | Workers only (B) | B | no timeout | | Both, different values | B | A | For language SDK tasks, the default is filled from the Dag processor's config when the Dag is parsed: https://github.com/apache/airflow/blob/99bdeabe3db437997d8d3c16353217fdaa350761/airflow-core/src/airflow/dag_processing/lang_sdk_processor.py#L430 (WOW it's kinda weird to the users isn't it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
