lucafuji commented on issue #6870: [AIRFLOW-0578] Check return code URL: https://github.com/apache/airflow/pull/6870#issuecomment-575817766 Besides that, I kind of remember why Max recommend me to change base_job. In airflow, it's base_job.run call base_job.execute and each sub class implements its own _execute function. And it's _execute's job to execute the actual command, but state management should be done in base_job.run, after _execute is done. The includes managing the state of the job and task instance We should not change the state in _execute. Therefore it might be better to implement a on_failure callback to be called after _execute. We can make default behaviour just do nothing and only implement specific logic in local_task_job.py
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
