This is an automated email from the ASF dual-hosted git repository.
jedcunningham pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 4639f244f84 Remove info tooltip from Dag version comparison (#75526)
4639f244f84 is described below
commit 4639f244f844040e5cf5f3abf5a643d1985604e9
Author: Jed Cunningham <[email protected]>
AuthorDate: Fri Oct 23 21:19:24 2026 -0600
Remove info tooltip from Dag version comparison (#75526)
The "About this comparison" icon on the Versions tab showed a hard to
follow caveat that added little to the page. Remove the icon, its test,
and the two now-unused translation keys from every locale.
---
.../src/airflow/ui/public/i18n/locales/ca/dag.json | 2 --
.../src/airflow/ui/public/i18n/locales/de/dag.json | 2 --
.../src/airflow/ui/public/i18n/locales/el/dag.json | 2 --
.../src/airflow/ui/public/i18n/locales/en/dag.json | 2 --
.../src/airflow/ui/public/i18n/locales/fr/dag.json | 2 --
.../src/airflow/ui/public/i18n/locales/he/dag.json | 2 --
.../src/airflow/ui/public/i18n/locales/hi/dag.json | 2 --
.../src/airflow/ui/public/i18n/locales/ko/dag.json | 2 --
.../src/airflow/ui/public/i18n/locales/pl/dag.json | 2 --
.../airflow/ui/public/i18n/locales/zh-TW/dag.json | 2 --
.../ui/src/pages/Dag/Versions/VersionDiff.test.tsx | 8 --------
.../ui/src/pages/Dag/Versions/VersionDiff.tsx | 22 ++++++----------------
12 files changed, 6 insertions(+), 44 deletions(-)
diff --git a/airflow-core/src/airflow/ui/public/i18n/locales/ca/dag.json
b/airflow-core/src/airflow/ui/public/i18n/locales/ca/dag.json
index 33981ccc603..9605ade5854 100644
--- a/airflow-core/src/airflow/ui/public/i18n/locales/ca/dag.json
+++ b/airflow-core/src/airflow/ui/public/i18n/locales/ca/dag.json
@@ -254,7 +254,6 @@
"title": "Magatzem de tasca"
},
"versions": {
- "aboutThisComparison": "Sobre aquesta comparació",
"base": "Comparar des de",
"categories": {
"asset": "Asset",
@@ -289,7 +288,6 @@
"maxChanges": "Màxim de canvis",
"maxChangesDefault": "Per defecte",
"noChanges": "Aquestes versions contenen el mateix estat.",
- "observedStateBoundary": "Compara l'estat emmagatzemat actualment, no les
dades del moment de creació. La comparació del codi font no està disponible per
a versions històriques; utilitzeu la pestanya Codi per a comparar el codi
font.",
"operations": {
"added": "Afegit",
"changed": "Modificat",
diff --git a/airflow-core/src/airflow/ui/public/i18n/locales/de/dag.json
b/airflow-core/src/airflow/ui/public/i18n/locales/de/dag.json
index feedb5214b3..a58468f93c1 100644
--- a/airflow-core/src/airflow/ui/public/i18n/locales/de/dag.json
+++ b/airflow-core/src/airflow/ui/public/i18n/locales/de/dag.json
@@ -302,7 +302,6 @@
"title": "Task Status Zwischenspeicher"
},
"versions": {
- "aboutThisComparison": "Über diesen Vergleich",
"base": "Vergleichen von",
"categories": {
"asset": "Datensatz (Asset)",
@@ -342,7 +341,6 @@
"maxChanges": "Maximale Änderungen",
"maxChangesDefault": "Standard",
"noChanges": "Es gibt keinen Unterschied zwischen diesen Versionen.",
- "observedStateBoundary": "Vergleicht aktuell gespeichterte Dagversionen.
Quellcodevergleich ist nicht verfügbar für alte Versionen; Code-Tab nutzen um
Quellcode zu vergleichen.",
"operations": {
"added": "Hinzugefügt",
"changed": "Geändert",
diff --git a/airflow-core/src/airflow/ui/public/i18n/locales/el/dag.json
b/airflow-core/src/airflow/ui/public/i18n/locales/el/dag.json
index 410a282d730..7301cfbd1d2 100644
--- a/airflow-core/src/airflow/ui/public/i18n/locales/el/dag.json
+++ b/airflow-core/src/airflow/ui/public/i18n/locales/el/dag.json
@@ -254,7 +254,6 @@
"title": "Αποθήκη Καταστάσεων Εργασίας"
},
"versions": {
- "aboutThisComparison": "Σχετικά με αυτήν τη σύγκριση",
"base": "Σύγκριση από",
"categories": {
"asset": "Οντότητα",
@@ -289,7 +288,6 @@
"maxChanges": "Μέγιστες αλλαγές",
"maxChangesDefault": "Προεπιλογή",
"noChanges": "Αυτές οι εκδόσεις έχουν την ίδια κατάσταση.",
- "observedStateBoundary": "Συγκρίνει την τρέχουσα αποθηκευμένη κατάσταση,
όχι στοιχεία από τη στιγμή της δημιουργίας. Η σύγκριση πηγαίου κώδικα δεν είναι
διαθέσιμη για ιστορικές εκδόσεις· χρησιμοποιήστε την καρτέλα Κώδικας για
σύγκριση πηγαίου κώδικα.",
"operations": {
"added": "Προστέθηκε",
"changed": "Άλλαξε",
diff --git a/airflow-core/src/airflow/ui/public/i18n/locales/en/dag.json
b/airflow-core/src/airflow/ui/public/i18n/locales/en/dag.json
index 0adce848164..c7f0c598906 100644
--- a/airflow-core/src/airflow/ui/public/i18n/locales/en/dag.json
+++ b/airflow-core/src/airflow/ui/public/i18n/locales/en/dag.json
@@ -302,7 +302,6 @@
"title": "Task State Store"
},
"versions": {
- "aboutThisComparison": "About this comparison",
"base": "Compare from",
"categories": {
"asset": "Asset",
@@ -342,7 +341,6 @@
"maxChanges": "Max changes",
"maxChangesDefault": "Default",
"noChanges": "These versions hold the same state.",
- "observedStateBoundary": "Compares currently stored state, not
creation-time evidence. Source comparison is unavailable for historical
versions; use the Code tab to compare source.",
"operations": {
"added": "Added",
"changed": "Changed",
diff --git a/airflow-core/src/airflow/ui/public/i18n/locales/fr/dag.json
b/airflow-core/src/airflow/ui/public/i18n/locales/fr/dag.json
index da22e065df5..c3a2b173711 100644
--- a/airflow-core/src/airflow/ui/public/i18n/locales/fr/dag.json
+++ b/airflow-core/src/airflow/ui/public/i18n/locales/fr/dag.json
@@ -263,7 +263,6 @@
"title": "Stockage d'état de tâche"
},
"versions": {
- "aboutThisComparison": "À propos de cette comparaison",
"base": "Comparer depuis",
"categories": {
"asset": "Asset",
@@ -298,7 +297,6 @@
"maxChanges": "Changements max.",
"maxChangesDefault": "Par défaut",
"noChanges": "Ces versions ont le même état.",
- "observedStateBoundary": "Compare l'état actuellement stocké, et non les
preuves au moment de la création. La comparaison des sources n'est pas
disponible pour les versions historiques ; utilisez l'onglet Code pour comparer
les sources.",
"operations": {
"added": "Ajouté",
"changed": "Modifié",
diff --git a/airflow-core/src/airflow/ui/public/i18n/locales/he/dag.json
b/airflow-core/src/airflow/ui/public/i18n/locales/he/dag.json
index 8560e873c6b..bda26827c54 100644
--- a/airflow-core/src/airflow/ui/public/i18n/locales/he/dag.json
+++ b/airflow-core/src/airflow/ui/public/i18n/locales/he/dag.json
@@ -294,7 +294,6 @@
"title": "מאגר מצבי משימות"
},
"versions": {
- "aboutThisComparison": "מידע על ההשוואה",
"base": "השווה מתוך",
"categories": {
"asset": "נכס",
@@ -329,7 +328,6 @@
"maxChanges": "מספר השינויים המרבי",
"maxChangesDefault": "ברירת מחדל",
"noChanges": "הגרסאות האלה מכילות את אותו מצב.",
- "observedStateBoundary": "ההשוואה מתייחסת למצב המאוחסן כעת, ולא לראיות
מזמן היצירה. אין אפשרות להשוות את המקור בגרסאות היסטוריות; השתמש בכרטיסייה Code
כדי להשוות את המקור.",
"operations": {
"added": "נוסף",
"changed": "השתנה",
diff --git a/airflow-core/src/airflow/ui/public/i18n/locales/hi/dag.json
b/airflow-core/src/airflow/ui/public/i18n/locales/hi/dag.json
index 4f7b867e0c1..5355328b842 100644
--- a/airflow-core/src/airflow/ui/public/i18n/locales/hi/dag.json
+++ b/airflow-core/src/airflow/ui/public/i18n/locales/hi/dag.json
@@ -302,7 +302,6 @@
"title": "Task State Store"
},
"versions": {
- "aboutThisComparison": "इस तुलना के बारे में",
"base": "इससे तुलना करें",
"categories": {
"asset": "एसेट",
@@ -342,7 +341,6 @@
"maxChanges": "अधिकतम परिवर्तन",
"maxChangesDefault": "डिफ़ॉल्ट",
"noChanges": "इन वर्शनों की स्थिति समान है।",
- "observedStateBoundary": "वर्तमान में संग्रहीत स्थिति की तुलना करता है,
निर्माण-समय के साक्ष्य की नहीं। ऐतिहासिक वर्शनों के लिए स्रोत तुलना उपलब्ध नहीं
है; स्रोत की तुलना करने के लिए कोड टैब का उपयोग करें।",
"operations": {
"added": "जोड़ा गया",
"changed": "बदला गया",
diff --git a/airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json
b/airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json
index f54715a3957..bcdaba9f8b0 100644
--- a/airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json
+++ b/airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json
@@ -301,7 +301,6 @@
"title": "태스크 상태 저장소"
},
"versions": {
- "aboutThisComparison": "이 비교에 대한 정보",
"base": "비교 기준",
"categories": {
"asset": "에셋",
@@ -336,7 +335,6 @@
"maxChanges": "최대 변경 수",
"maxChangesDefault": "기본값",
"noChanges": "두 버전에 저장된 상태가 같습니다.",
- "observedStateBoundary": "버전 생성 시점의 기록이 아니라 현재 저장된 상태를 비교합니다. 이전 버전은 소스
비교를 지원하지 않으므로, 소스를 비교하려면 코드 탭을 사용하세요.",
"operations": {
"added": "추가됨",
"changed": "변경됨",
diff --git a/airflow-core/src/airflow/ui/public/i18n/locales/pl/dag.json
b/airflow-core/src/airflow/ui/public/i18n/locales/pl/dag.json
index bdba313ed1b..2c130e9f93b 100644
--- a/airflow-core/src/airflow/ui/public/i18n/locales/pl/dag.json
+++ b/airflow-core/src/airflow/ui/public/i18n/locales/pl/dag.json
@@ -272,7 +272,6 @@
"title": "Magazyn stanu zadania"
},
"versions": {
- "aboutThisComparison": "O tym porównaniu",
"base": "Porównaj od",
"categories": {
"asset": "Zasób",
@@ -307,7 +306,6 @@
"maxChanges": "Maksymalna liczba zmian",
"maxChangesDefault": "Domyślna",
"noChanges": "Te wersje mają ten sam stan.",
- "observedStateBoundary": "Porównuje aktualnie zapisany stan, a nie dane z
chwili utworzenia. Porównanie kodu źródłowego nie jest dostępne dla wersji
historycznych; aby porównać kod źródłowy, użyj zakładki Kod.",
"operations": {
"added": "Dodano",
"changed": "Zmieniono",
diff --git a/airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/dag.json
b/airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/dag.json
index 69b90bda7ee..cec6a08d46f 100644
--- a/airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/dag.json
+++ b/airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/dag.json
@@ -302,7 +302,6 @@
"title": "任務儲存區"
},
"versions": {
- "aboutThisComparison": "關於此比較",
"base": "比較起點",
"categories": {
"asset": "資源",
@@ -342,7 +341,6 @@
"maxChanges": "變更數上限",
"maxChangesDefault": "預設",
"noChanges": "這些版本的狀態相同。",
- "observedStateBoundary":
"比較的是目前儲存的狀態，而非建立當時的證據。歷史版本無法比較原始碼；請使用「程式碼」分頁比較原始碼。",
"operations": {
"added": "新增",
"changed": "變更",
diff --git
a/airflow-core/src/airflow/ui/src/pages/Dag/Versions/VersionDiff.test.tsx
b/airflow-core/src/airflow/ui/src/pages/Dag/Versions/VersionDiff.test.tsx
index 4938d347b6d..565e4633068 100644
--- a/airflow-core/src/airflow/ui/src/pages/Dag/Versions/VersionDiff.test.tsx
+++ b/airflow-core/src/airflow/ui/src/pages/Dag/Versions/VersionDiff.test.tsx
@@ -153,14 +153,6 @@ describe("VersionDiff", () => {
}
});
- it("keeps the comparison's boundary reachable from above the table", () => {
- renderDiff(redacted);
-
- // Below the table it would be pushed off-screen by exactly the long diffs
that need it.
-
expect(screen.queryByText("versions.observedStateBoundary")).not.toBeInTheDocument();
- expect(screen.getByRole("button", { name: "versions.aboutThisComparison"
})).toBeInTheDocument();
- });
-
it("shows values and the identifying path once the caller may see them", ()
=> {
renderDiff(authorized);
diff --git a/airflow-core/src/airflow/ui/src/pages/Dag/Versions/VersionDiff.tsx
b/airflow-core/src/airflow/ui/src/pages/Dag/Versions/VersionDiff.tsx
index 0e0a15cdd26..aefbc32953e 100644
--- a/airflow-core/src/airflow/ui/src/pages/Dag/Versions/VersionDiff.tsx
+++ b/airflow-core/src/airflow/ui/src/pages/Dag/Versions/VersionDiff.tsx
@@ -19,7 +19,6 @@
import { Badge, Box, Heading, Text } from "@chakra-ui/react";
import type { TFunction } from "i18next";
import { useTranslation } from "react-i18next";
-import { LuInfo } from "react-icons/lu";
import type { DagVersionDiffChangeResponse, DagVersionDiffResponse } from
"openapi/requests/types.gen";
@@ -151,23 +150,14 @@ export const VersionDiff = ({ baseVersionNumber, diff,
targetVersionNumber }: Ve
hideRowCountHeading
modelName="dag:versions.record"
noRowsMessage={translate("versions.noChanges")}
+ // The hover says what grants values, since the viewer cannot grant it
here: the server
+ // decides from the caller's access to Dag code.
presentationActions={
- <>
- {/* The hover says what grants values, since the viewer cannot grant
it here: the server
- decides from the caller's access to Dag code. */}
- {valuesShown ? undefined : (
- <Tooltip content={translate("versions.codeAccess")} portalled>
- <Badge
colorPalette="gray">{translate("versions.valuesHidden")}</Badge>
- </Tooltip>
- )}
- {/* Above the table rather than below it: a long diff would
otherwise push the caveat
- off-screen exactly when it matters most. */}
- <Tooltip content={translate("versions.observedStateBoundary")}
portalled>
- <Box aria-label={translate("versions.aboutThisComparison")}
as="button" color="fg.muted" p={1}>
- <LuInfo />
- </Box>
+ valuesShown ? undefined : (
+ <Tooltip content={translate("versions.codeAccess")} portalled>
+ <Badge
colorPalette="gray">{translate("versions.valuesHidden")}</Badge>
</Tooltip>
- </>
+ )
}
total={diff.changes.length}
/>
