potiuk commented on code in PR #75612:
URL: https://github.com/apache/airflow/pull/75612#discussion_r4371518534
##########
.github/workflows/ci-amd.yml:
##########
@@ -423,6 +424,30 @@ jobs:
env:
SKIP_BREEZE_SELF_UPGRADE_CHECK: "true"
GITHUB_CONTEXT_INPUT: "${{ runner.temp }}/github_context.json"
+ # The newsfragment check of static checks fails a newsfragment of the
pull request that is
+ # named after another number. A push in a fork (AIP-120) has no pull
request in its event,
+ # so the open pull request of the pushed branch is looked up; without
one, any number passes.
Review Comment:
You're right, a fork push made before the PR exists is not checked; it's
listed under "Not covered" in the description. We'll close that in the
reconciler as a follow-up, so it checks the PR's newsfragment names before
posting `CI passed`. PRs opened before this change need a rebase onto the
latest `main` to get the check.
---
Drafted-by: Claude Opus 5; reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
