sameerpandey17 commented on PR #75635: URL: https://github.com/apache/airflow/pull/75635#issuecomment-6406654570
Note on the diff size (roughly -80 / +35): most of it is deleting code that no longer has a caller, not new behaviour. Removed (approximate line counts): - `_prefix_range_upper`, which has no callers left: ~23 - its 3 tests: ~25 - old docstrings and comments describing the upper bound: ~15 - replaced assertions and the now-unused `_PrefixPatternParam` import: ~10 - the logic change itself (signature, the two callers, the return): ~10 Added: the new `test_no_upper_bound_for_collation_safety`, the updated docstrings, and `substr` / "no `<` clause" assertions replacing the old `< 'upper'` ones (~35). The behaviour change is only dropping the `col < upper` condition. If you'd prefer a smaller diff, I'm happy to move the cleanup (removing `_prefix_range_upper` and its tests) into a follow-up PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
