anamargaridarl commented on code in PR #75220:
URL: https://github.com/apache/airflow/pull/75220#discussion_r4376985368
##########
chart/templates/workers/worker-kedaautoscaler.yaml:
##########
@@ -60,19 +60,29 @@ spec:
triggers:
{{- if eq .Values.data.metadataConnection.protocol "mysql" }}
- type: "mysql"
+ {{- with .Values.workers.celery.keda.authenticationRef }}
+ authenticationRef: {{- toYaml . | nindent 8 }}
+ {{- end }}
metadata:
queryValue: "1"
+ {{- if not .Values.workers.celery.keda.authenticationRef }}
connectionStringFromEnv: KEDA_DB_CONN
+ {{- end }}
query: {{ tpl .Values.workers.celery.keda.query . | quote }}
{{- else }}
- type: "postgresql"
+ {{- with .Values.workers.celery.keda.authenticationRef }}
+ authenticationRef: {{- toYaml . | nindent 8 }}
+ {{- end }}
metadata:
targetQueryValue: "1"
+ {{- if not .Values.workers.celery.keda.authenticationRef }}
Review Comment:
Thanks for the quick review! I removed the environment variable KEDA_DB_CONN
in keda_airflow_environment when authenticationRef is enabled. This removes
errors like CreateContainerConfigError, as you mentioned, and avoids adding any
unused variables. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
