Lee-W opened a new pull request, #75706:
URL: https://github.com/apache/airflow/pull/75706
* Refuse Human-in-the-loop responses once the task stopped waiting
The hitlDetails PATCH recorded a response whenever none existed yet and only
resumed the task if it was still awaiting input or deferred. After a
response_timeout without defaults, an answer was stored and returned 200
although nothing resumed, so the UI reported success for a decision that never
took effect.
Return 409 before writing when the task instance is in any other state. The
check runs under the existing task instance lock, after the authorization and
option validation, and looks at the state only: a request whose timeout has
passed but that the scheduler has not yet processed is still accepted.
* Show why the backend refused a Human-in-the-loop response
The error toast showed only the HTTP status text ("Conflict") when a
response was refused. Show the detail the backend returns, such as that the
task is no longer waiting for a response, and fall back to the previous message
when there is none.
* Cover the refusal toast for validation, mapping, missing and forbidden
details
(cherry picked from commit d1491b82c90d9c5178021885f16f8df1ca564b53)
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
