uranusjr commented on code in PR #75707:
URL: https://github.com/apache/airflow/pull/75707#discussion_r4385322973
##########
task-sdk/src/airflow/sdk/coordinators/_subprocess.py:
##########
@@ -365,6 +379,11 @@ def start( # type: ignore[override]
stdout=stdout_w.fileno(),
stderr=stderr_w.fileno(),
env=_build_runtime_env(),
+ # Own process group, so the supervisor can signal everything
the runtime
+ # spawned with os.killpg, as the Python task runner has done
since #65505.
+ # Popen returns only once the child has exec'd, so the group
always exists
+ # before kill() can run.
Review Comment:
```suggestion
# Popen returns after exec, so the group exists before
kill().
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
