Lee-W commented on code in PR #74569:
URL: https://github.com/apache/airflow/pull/74569#discussion_r4387560253
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/hitl.py:
##########
@@ -100,6 +105,43 @@ def __getattr__(self, name: str) -> Any:
return getattr(self.value, name)
+def _check_params_input(params: Mapping[str, Any], params_input: Mapping[str,
Any]) -> str | None:
Review Comment:
It would be better to just raise an exception here and catch it at the call
site. I'd expect `check` / `validate` to raise an exception if the check fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
