kaxil commented on code in PR #75795:
URL: https://github.com/apache/airflow/pull/75795#discussion_r4390962267
##########
airflow-core/src/airflow/models/taskinstance.py:
##########
@@ -1141,6 +1141,11 @@ class TaskInstance(Base, LoggingMixin, BaseWorkload):
priority_weight: Mapped[int | None] = mapped_column(Integer, nullable=True)
operator: Mapped[str | None] = mapped_column(String(1000), nullable=True)
custom_operator_name: Mapped[str | None] = mapped_column(String(1000),
nullable=True)
+ # Denormalized from the task so ti_run can tell a stub (foreign-runtime)
task from a regular one
+ # without loading the serialized Dag. Null on rows written before the
column existed. A row moved
Review Comment:
3.4.0b1 and b2 already send `arg_bindings` from `ti_run` but have no
`is_stub` column, so a stub TI queued before upgrading from a beta reads null
and runs without its arguments. A retry carries the null forward too, since
`prepare_db_for_next_try` copies the column. Would `if ti.is_stub is not False`
work in the route? Rows written after the migration always have a bool, so it
only changes what happens to these old rows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
