luc-pimentel commented on PR #75028: URL: https://github.com/apache/airflow/pull/75028#issuecomment-6456572201
Just to add a bit more context here: it looks like `wait_for_past_depends_before_skipping` never worked for scheduled runs, so this isn't a 3.x regression. The option came in with #27710 in 2.6.0. In 2.x the dependency checks only read it from `DepContext`, and the only thing that set it was [`airflow tasks run --depends-on-past wait`](https://github.com/apache/airflow/blob/2.6.0/airflow/cli/commands/task_command.py#L240) run by hand. The scheduler's [contexts in `DagRun`](https://github.com/apache/airflow/blob/2.6.0/airflow/models/dagrun.py#L766-L770) left it off, and the [command it sent to executors](https://github.com/apache/airflow/blob/2.6.0/airflow/jobs/scheduler_job_runner.py#L646-L649) didn't add it. #47453 removed that CLI option in 3.0, so nothing sets the flag now. I ran a Dag like the one in #55146 on the released 2.x images with `airflow standalone`: run 1 fails the task, run 2 skips it. With the flag on, the task was skipped right away both when `ShortCircuitOperator` skips it directly and when its trigger rule skips it, which is the case #27710 was written for: | Release | Skipped by the short-circuit | Skipped by its trigger rule | | --- | --- | --- | | 2.6.0 | `skipped` | `skipped` | | 2.10.5 | `skipped` | `skipped` | --- Drafted-by: Claude Code (Opus 5.5); reviewed by @luc-pimentel before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
