dabla commented on PR #75774: URL: https://github.com/apache/airflow/pull/75774#issuecomment-6469921268
> Thanks for the review @dabla, all three points addressed in [44f8716](https://github.com/apache/airflow/commit/44f87164b7ac8729d67fa4823bb2df91dbcb9192): > > * **[1] sleep defer deadline:** the `TimeDeltaTrigger` sleep now defers with > `timeout=remaining + retry_delay`. That always lands after the sleep itself, so it never > races the final poll, and a lost sleep trigger ends through `TaskDeferralTimeout` → > `AirflowSensorTimeout` in `resume_execution`, with `soft_fail` / `never_fail` applied. > Pinned in `test_execute_complete_redefers_with_capped_sleep_and_started_at` and > `test_sleep_capped_to_remaining`. > * **[2] `timeout is None`:** agreed, `_coerce_timeout` makes it unreachable on both the Task > SDK and 2.11. Removed the branches and `test_timeout_attribute_none_never_times_out`; > `_remaining_timeout` now returns `float`. > * **[3] naming:** `_anchor` is now `_started_at`, and the tests use `started_at` throughout. > > Azure sensors suite + msgraph trigger tests: 79 passed. prek and mypy-providers pass. Thanks Mathieu, approved, do not forget to resolve conversations if those are addressed, that makes it easier for us to see which comments have been addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
