This is an automated email from the ASF dual-hosted git repository.
hussein-awala pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 2f5c1c4b26b Remove unused UI page-object methods (#75853)
2f5c1c4b26b is described below
commit 2f5c1c4b26b3936a51277aff3d2be78020a4a01b
Author: Hussein Awala <[email protected]>
AuthorDate: Wed Oct 28 14:42:28 2026 +0100
Remove unused UI page-object methods (#75853)
---
.../airflow/ui/tests/e2e/pages/DagCalendarTab.ts | 11 -------
.../src/airflow/ui/tests/e2e/pages/DagsPage.ts | 4 ---
.../airflow/ui/tests/e2e/pages/ProvidersPage.ts | 13 --------
.../airflow/ui/tests/e2e/pages/TaskInstancePage.ts | 36 +---------------------
4 files changed, 1 insertion(+), 63 deletions(-)
diff --git a/airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts
b/airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts
index 12f46dd1012..56c5af3786e 100644
--- a/airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts
+++ b/airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts
@@ -23,16 +23,11 @@ import { BasePage } from "tests/e2e/pages/BasePage";
export class DagCalendarTab extends BasePage {
public readonly dailyToggle: Locator;
public readonly hourlyToggle: Locator;
- public readonly totalToggle = this.page.getByRole("button", { name: /total/i
});
public get activeCells(): Locator {
return
this.page.locator('[data-testid="calendar-cell"][data-has-data="true"]');
}
- public get calendarCells(): Locator {
- return this.page.getByTestId("calendar-cell");
- }
-
public constructor(page: Page) {
super(page);
@@ -80,12 +75,6 @@ export class DagCalendarTab extends BasePage {
await this.waitForCalendarReady();
}
- public async switchToTotalView(): Promise<void> {
- await this.totalToggle.click();
-
- await expect(this.page).toHaveURL(/calendar-view-mode=total/u);
- }
-
private async waitForCalendarReady(): Promise<void> {
await expect(this.page.getByTestId("dag-calendar-root")).toBeVisible({
timeout: 120_000 });
diff --git a/airflow-core/src/airflow/ui/tests/e2e/pages/DagsPage.ts
b/airflow-core/src/airflow/ui/tests/e2e/pages/DagsPage.ts
index 537e2f88af5..cc8dc68096b 100644
--- a/airflow-core/src/airflow/ui/tests/e2e/pages/DagsPage.ts
+++ b/airflow-core/src/airflow/ui/tests/e2e/pages/DagsPage.ts
@@ -70,10 +70,6 @@ export class DagsPage extends BasePage {
return `/dags/${dagName}`;
}
- public static getDagRunDetailsUrl(dagName: string, dagRunId: string): string
{
- return `/dags/${dagName}/runs/${dagRunId}/details`;
- }
-
/**
* Clear the search input and wait for list to reset
*/
diff --git a/airflow-core/src/airflow/ui/tests/e2e/pages/ProvidersPage.ts
b/airflow-core/src/airflow/ui/tests/e2e/pages/ProvidersPage.ts
index a8e983cbede..73e0a6a0578 100644
--- a/airflow-core/src/airflow/ui/tests/e2e/pages/ProvidersPage.ts
+++ b/airflow-core/src/airflow/ui/tests/e2e/pages/ProvidersPage.ts
@@ -24,19 +24,15 @@ import { DATA_ROWS } from "tests/e2e/utils/ui/selectors";
import { BasePage } from "./BasePage";
export class ProvidersPage extends BasePage {
- public readonly adminMenuButton: Locator;
public readonly heading: Locator;
- public readonly providersMenuItem: Locator;
public readonly rows: Locator;
public readonly table: Locator;
public constructor(page: Page) {
super(page);
- this.adminMenuButton = page.getByRole("button", { name: /^admin$/i });
// DataTable's row count is the page heading, so this reads "90 Providers"
rather than "Providers"
this.heading = page.getByRole("heading", { name: /providers/i });
- this.providersMenuItem = page.getByRole("menuitem", { name: /^providers$/i
});
this.table = page.getByTestId("table-list");
this.rows = this.table.locator(DATA_ROWS).filter({
has: page.locator("td"),
@@ -70,15 +66,6 @@ export class ProvidersPage extends BasePage {
}).toPass({ intervals: [2000], timeout: 60_000 });
}
- public async navigateFromAdminMenu(): Promise<void> {
- await expect(async () => {
- await this.navigateTo("/");
- await this.adminMenuButton.click();
- await expect(this.providersMenuItem).toBeVisible();
- }).toPass({ intervals: [2000], timeout: 60_000 });
- await this.providersMenuItem.click();
- }
-
public packageLinkAt(index: number): Locator {
return this.rows.nth(index).locator("td").nth(0).getByRole("link");
}
diff --git a/airflow-core/src/airflow/ui/tests/e2e/pages/TaskInstancePage.ts
b/airflow-core/src/airflow/ui/tests/e2e/pages/TaskInstancePage.ts
index b6b89b05fe9..62d07c2b1bc 100644
--- a/airflow-core/src/airflow/ui/tests/e2e/pages/TaskInstancePage.ts
+++ b/airflow-core/src/airflow/ui/tests/e2e/pages/TaskInstancePage.ts
@@ -16,29 +16,11 @@
* specific language governing permissions and limitations
* under the License.
*/
-import { expect, type Locator, type Page } from "@playwright/test";
+import { expect } from "@playwright/test";
import { BasePage } from "./BasePage";
export class TaskInstancePage extends BasePage {
- public readonly confirmTriggerButton: Locator;
- public readonly stateBadge: Locator;
- public readonly triggerButton: Locator;
-
- public constructor(page: Page) {
- super(page);
- this.triggerButton = page.getByTestId("trigger-dag-button");
- this.confirmTriggerButton = page.getByTestId("trigger-dag-submit");
- this.stateBadge =
page.getByTestId("header-card").getByTestId("state-badge").first();
- }
-
- public async navigateToDag(dagId: string): Promise<void> {
- await expect(async () => {
- await this.navigateTo(`/dags/${dagId}`);
- await expect(this.triggerButton).toBeVisible({ timeout: 5000 });
- }).toPass({ intervals: [2000], timeout: 60_000 });
- }
-
public async navigateToTaskInstance(dagId: string, runId: string, taskId:
string): Promise<void> {
await expect(async () => {
await this.navigateTo(`/dags/${dagId}/runs/${runId}/tasks/${taskId}`);
@@ -46,20 +28,4 @@ export class TaskInstancePage extends BasePage {
await expect(this.page.locator("#details-panel")).toBeVisible();
}).toPass({ intervals: [2000], timeout: 60_000 });
}
-
- public async triggerDagAndWaitForSuccess(dagId: string): Promise<void> {
- await this.triggerDagRun(dagId);
- await this.waitForDagRunSuccess();
- }
-
- public async triggerDagRun(dagId: string): Promise<void> {
- await this.navigateToDag(dagId);
- await this.triggerButton.click();
- await this.confirmTriggerButton.click();
- await this.page.waitForURL(/.*\/runs\/.*/, { timeout: 15_000 });
- }
-
- public async waitForDagRunSuccess(): Promise<void> {
- await expect(this.stateBadge).toContainText("Success", { timeout: 60_000
});
- }
}
