pierrejeambrun commented on code in PR #68854: URL: https://github.com/apache/airflow/pull/68854#discussion_r4402661823
########## airflow-core/src/airflow/api_fastapi/core_api/datamodels/providers.py: ########## Review Comment: Since keys the models don't declare are silently dropped, would it be worth a small test that compares the top-level properties of provider_info.schema.json (minus the deprecated hook-class-names / dataset-uris) with the validation_aliases of ProviderInfoResponse? Then a new key added to the schema fails a test instead of quietly going missing from the API. Not blocking. ########## airflow-core/src/airflow/ui/openapi-gen/requests/schemas.gen.ts: ########## Review Comment: Since keys the models don't declare are silently dropped, would it be worth a small test that compares the top-level properties of provider_info.schema.json (minus the deprecated hook-class-names / dataset-uris) with the validation_aliases of ProviderInfoResponse? Then a new key added to the schema fails a test instead of quietly going missing from the API. Not blocking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
