Copilot commented on code in PR #75911: URL: https://github.com/apache/airflow/pull/75911#discussion_r4406378804
########## devel-common/src/sphinx_exts/extra_provider_files_with_substitutions.py: ########## @@ -17,11 +17,14 @@ from __future__ import annotations import os +import re from datetime import datetime from pathlib import Path from packaging.version import Version +_LEGACY_RELEASE_HEADING = re.compile(r"^<h2>(?:[0-9]+!)?[0-9]+(?:\.[0-9]+)*<a") Review Comment: Optional: `_LEGACY_RELEASE_HEADING` matches the current bare-version headings emitted by `dev/breeze/src/airflow_breeze/templates/CHANGELOG_TEMPLATE.rst.jinja2`, so “legacy” incorrectly suggests an obsolete format. Rename it to `_RELEASE_VERSION_HEADING` and update both uses. Likewise, name the tests in `devel-common/tests/unit/sphinx_exts/test_extra_provider_files_with_substitutions.py:40` and `:75` after their heading shapes rather than “modern” and “legacy”. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
