uranusjr commented on PR #73015: URL: https://github.com/apache/airflow/pull/73015#issuecomment-6492347627
A high-level design question: Should archive mode be a separate class? Using `archive_key` as a switch adds a lot of branching, and it’s easier to miss a branch if additional logic is added to the bundle. We could unify the user-facing interface by having _two_ subclasses, one with `archive_key` and one without, and implement `__new__` on S3DagBundle to dispatch based on arguments. It would make the implementation cleaner IMO. We could obviously just have S3DagBundle and S3ArchiveDagBundle if it’s good enough. It might also be a good idea to prepare for extracting things like `_extract_archive` out of the provider since those really are not specific to S3. It’s difficult to manage provider compatibility though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
