baptistegh commented on code in PR #75913:
URL: https://github.com/apache/airflow/pull/75913#discussion_r4413619453
##########
providers/keycloak/src/airflow/providers/keycloak/auth_manager/keycloak_auth_manager.py:
##########
@@ -234,6 +241,17 @@ def get_url_logout(self) -> str | None:
base_url = conf.get("api", "base_url", fallback="/")
return urljoin(base_url, f"{AUTH_MANAGER_FASTAPI_APP_PREFIX}/logout")
+ def get_cli_login_methods(self) -> CliLoginMethods:
+ methods = CliLoginMethods(
+ grant_types_supported=["password", "refresh_token"],
+ token_endpoint=f"{AUTH_MANAGER_FASTAPI_APP_PREFIX}/token/cli",
Review Comment:
This is already handled: `AUTH_MANAGER_FASTAPI_APP_PREFIX` is
`f"{API_ROOT_PATH}auth"` with `API_ROOT_PATH = urlsplit(base_url).path`
(`api_fastapi/app.py`), so the `[api] base_url` path is in there.
Using `urljoin(base_url, ...)` the way `get_url_login`
does would return a full URL and break that contract, so I left it as is.
Happy to change it if you read the contract differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
