kaxil commented on code in PR #75909:
URL: https://github.com/apache/airflow/pull/75909#discussion_r4406062948
##########
providers/common/ai/docs/self_hosted_models.rst:
##########
@@ -293,9 +293,10 @@ above.
Model identifier format
^^^^^^^^^^^^^^^^^^^^^^^^
-The ``extra`` JSON's ``model`` value keeps the ``provider:model`` format the
-hook always expects, but which ``provider`` prefix to use depends on the
-endpoint:
+The ``extra`` JSON's ``model`` value keeps the ``provider:model`` format (or
+set the prefix once as Default Provider, see
+:ref:`conn-example-openai-compatible-gateway`), but which ``provider`` prefix
to
+use depends on the endpoint:
- **vLLM** has no dedicated provider class in pydantic-ai -- ``openai:<model>``
Review Comment:
Updated in a23004a to list both `openai:` and `openai-chat:` for vLLM.
##########
providers/common/ai/tests/unit/common/ai/hooks/test_pydantic_ai.py:
##########
@@ -737,6 +737,76 @@ def
test_generic_connection_typo_prefix_names_the_bad_segment(self, registry, in
assert "openi" in str(exc_info.value)
assert "openi:gpt-5" in str(exc_info.value)
+ @pytest.mark.parametrize(
+ ("model_id", "extra_model"),
+ [
+ pytest.param(None, "claude-sonnet-4-5", id="model-in-extra"),
+ pytest.param("claude-sonnet-4-5", None, id="model-id-param"),
+ ],
+ )
+ def test_generic_connection_provider_extra_qualifies_bare_name(
Review Comment:
Added in a23004a:
`test_generic_connection_provider_extra_builds_the_gateway_model` builds the
real `OpenAIChatModel` from the docs' gateway connection and checks its model
name and base URL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
