uranusjr commented on code in PR #75920:
URL: https://github.com/apache/airflow/pull/75920#discussion_r4420931065
##########
java-sdk/sdk/src/test/kotlin/org/apache/airflow/sdk/execution/CommTest.kt:
##########
@@ -183,24 +183,30 @@ class CommsTest {
return out.toByteArray()
}
- private fun notFoundResponseFrame(id: Int): ByteArray {
- val out = ByteArrayOutputStream()
- MessagePack.newDefaultPacker(out).use { packer ->
- packer.packArrayHeader(3)
- packer.packInt(id)
- packer.packNil()
- packer.packMapHeader(3)
- packer.packString("type")
- packer.packString("ErrorResponse")
- packer.packString("error")
- packer.packString("TASK_STORE_NOT_FOUND")
- packer.packString("detail")
- packer.packMapHeader(1)
- packer.packString("key")
- packer.packString("job_id")
+ // An ErrorResponse carrying a typed `error` code and a one-entry `detail`,
as the supervisor sends it.
+ private fun typedErrorFrame(
Review Comment:
We can probably do the same for success replies, but this is probably out of
this PR’s scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
