dhirajkk91 commented on code in PR #75917: URL: https://github.com/apache/airflow/pull/75917#discussion_r4434116347
########## providers/git/tests/unit/git/hooks/test_git.py: ########## @@ -24,19 +24,25 @@ import pathlib import shlex import socketserver +import ssl import subprocess import tempfile import threading import warnings -from datetime import UTC +from datetime import UTC, datetime from unittest import mock import pytest -from git import Repo +from cryptography import x509 +from cryptography.hazmat.primitives import hashes, serialization +from cryptography.hazmat.primitives.asymmetric import ec +from cryptography.x509.oid import NameOID Review Comment: Moved them into the helper, thanks. I looked for a simpler way to make a self-signed cert, but cryptography doesn't seem to have a higher-level helper for it, so I kept the same builder calls that task-sdk/tests/task_sdk/api/test_client.py uses. Happy to change it if you'd prefer a different approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
