shahar1 commented on code in PR #72954:
URL: https://github.com/apache/airflow/pull/72954#discussion_r4432050283
##########
providers/google/src/airflow/providers/google/cloud/utils/credentials_provider.py:
##########
@@ -397,9 +398,19 @@ def
_get_credentials_using_credential_config_file_and_token_supplier(self):
"Credential Configuration File is needed to use authentication
by External Identity Provider."
)
+ extra_params = self.idp_extra_params_dict or {}
+ if reserved :=
sorted(RESERVED_TOKEN_REQUEST_FIELDS.intersection(extra_params)):
Review Comment:
nit (optional): `oidc_issuer_url` is also a named argument of
`ClientCredentialsGrantFlowTokenSupplier.__init__`, so an extra named
`oidc_issuer_url` still fails at this call with `TypeError: got multiple values
for keyword argument 'oidc_issuer_url'`, the same confusing failure the PR
description says it removes for `client_id` and `client_secret`. It is not a
token-request field, so it does not belong in `RESERVED_TOKEN_REQUEST_FIELDS`,
but checking it here too would give the same clear `ValueError`. Fine to leave
for a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
