Eason09053360 commented on code in PR #75601:
URL: https://github.com/apache/airflow/pull/75601#discussion_r4436211400
##########
go-sdk/pkg/execution/client.go:
##########
@@ -468,9 +473,15 @@ func (s taskStateStore) Set(
// The caller's value is checked first so a misconfigured deployment
cannot
// mask a programming error in the task.
- if err := validateJSONRepresentable(value); err != nil {
+ decoded, err := validateJSONRepresentable(value)
+ if err != nil {
return fmt.Errorf("cannot set task state key %q: %w", key, err)
}
+ // Checked after decoding: a typed nil such as a nil *string is not ==
nil,
+ // yet it still encodes to null, which the Execution API rejects.
+ if decoded == nil {
+ return fmt.Errorf("cannot set task state key %q: value must not
be nil", key)
+ }
Review Comment:
Applied in c43c7be, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
