justinpakzad commented on code in PR #76243: URL: https://github.com/apache/airflow/pull/76243#discussion_r4436929213
########## dev/breeze/doc/ci/08_fork_ci_for_external_contributors.md: ########## @@ -164,6 +164,13 @@ cron trigger, and selective checks force the full matrix for `schedule` events. every enabled fork would run the full canary matrix twice a day on the contributor's concurrency cap. A manual `workflow_dispatch` in a fork still runs. +The same applies to every other workflow with a `schedule` trigger: a fork that enables +Actions gets all of their crons too. Their jobs carry a job-level +`if: github.repository == 'apache/airflow'` guard, combined with +`github.event_name != 'schedule'` when the workflow has other triggers that should still run +in a fork. A new scheduled workflow needs the same guard. The guard skips the jobs but not Review Comment: It doesn't need to be in this PR (I'm happy to take it on as well) but nothing enforces new scheduled workflows are guarded. Do you think its worth a prek hook or shall we hold off on that for now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
