aaron-y-chen opened a new pull request, #76269:
URL: https://github.com/apache/airflow/pull/76269

   Java SDK communication tests repeat the same MessagePack success envelope 
for several response types. Following the [review suggestion on 
#75920](https://github.com/apache/airflow/pull/75920#discussion_r4420931065), 
extract a private `successFrame` helper in `CommTest.kt` that derives the body 
map size from the supplied fields and preserves their wire value types.
   
   Keep the reusable XCom and OK wrappers and move the task state store, Dag 
run state, and Dag result payloads to their single call sites. The unknown-type 
fixture also uses the shared envelope helper. This refactors test fixtures 
without changing runtime behavior.
   
   ## Testing
   
   - `CommsTest` (`./gradlew :sdk:test --tests 
org.apache.airflow.sdk.execution.CommsTest`): all 28 tests pass before and 
after the refactor.
   - Temporary byte-for-byte comparisons: all 21 cases match across six 
payloads, three request IDs, and a custom XCom key. The temporary comparison 
test was removed after verification.
   - `./gradlew :sdk:spotlessCheck` and `git diff --check`: passed.
   - `./gradlew :sdk:ktlintCheck`: could not complete because the Gradle worker 
exits with code 139, including retries with a single worker and JDK 21. No lint 
result was produced for the changed test file.
   
   ---
   
   ### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Codex (GPT-6) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

  • [PR] Share success reply fram... aaron-y-chen (via GitHub) via commits

Reply via email to