uranusjr commented on code in PR #75959:
URL: https://github.com/apache/airflow/pull/75959#discussion_r4439303787
##########
ts-sdk/scripts/validate-release-inputs.mjs:
##########
@@ -127,7 +127,8 @@ export function validateReleaseInputs({ releaseTag, npmTag,
currentDistTagVersio
return {
version,
packageName: PACKAGE_NAME,
- packageFile: `${PACKAGE_NAME}-${version}.tgz`,
+ // npm pack names a scoped tarball without the "@" and with "/" as "-".
+ packageFile: `${PACKAGE_NAME.replace(/^@/, "").replace("/",
"-")}-${version}.tgz`,
Review Comment:
This might drift? `npm pack --json` already reports filename, and
`scripts/verify-package.mjs` has `parsePackMetadata` for it. Maybe the _Create
package tarball_ step can simply take the name from `npm pack --json` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
