Andrushika opened a new pull request, #76289:
URL: https://github.com/apache/airflow/pull/76289

   ## Background
   
   GitHub holds the CI runs of a fork pull request until a maintainer approves 
them. `auto-approve-workflow-runs` approves the safe runs every 15 minutes. It 
labels the other pull requests `need workflow approval`. If a pull request runs 
its CI in the contributor's fork, the gate in its `Tests (AMD)` run skips 
project CI. The workflow holds this run only if the pull request changes CI 
definition files.
   
   ## Why
   
   Approving that held run does not start project CI. On #76136, the approved 
run only executed `Fork CI gate` 
([run](https://github.com/apache/airflow/actions/runs/41202827540)). Project CI 
starts only after a maintainer adds `use project ci`. When the fork run is 
green, the fork CI reconciler asks for that step with `needs project ci`. 
#76267 has both labels for the same change. #75743 keeps `need workflow 
approval` while its fork run fails.
   
   ## What
   
   The workflow still holds these runs and sets the pending `Workflow approval` 
status. It no longer adds `need workflow approval`. If the label is already 
there, it removes it.
   
   The new tests in `test_workflow_run_approval.py` fail without the change. 
This conflicts with #76282 in `workflow_run_approval.py` and the fork CI doc. I 
will rebase when it merges.
   
   related: #76282
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (Claude Code)
   
   Generated-by: Claude Code (Claude Opus 5.5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to