Chinmay1220 commented on PR #68344: URL: https://github.com/apache/airflow/pull/68344#issuecomment-6587538486
Thanks @xlsongc, both for the live check against a real ADLS Gen2 account and for the nudge. Yes, I'm still finishing this one, my bad for the slow turnaround. Just pushed an update, rebased onto current `main`: - **Custom-domain case** (@potiuk's 29 Aug inline): now an `account_host` case. The bare account name goes in `host` and the custom domain in `extra.account_host`, so the test asserts `account_name` + `account_host` (both real adlfs parameters) instead of the dropped `account_url`. - **Full DFS endpoint case:** removed from the `test_get_fs` parametrize, since the only thing it could assert there was the same dead `account_url` key. What it was actually guarding, that a full endpoint is never treated as a bare account name, is now pinned directly by a small `test_bare_account_name_from_host` (dotted host, scheme, port, path, empty and `None`). `test_adls.py` passes locally (19 passed, Linux / Python 3.12). No changes to `adls.py`. As discussed, the pre-existing `account_url` path for WASB and full-URL hosts is left as it is on `main`; happy to look at that in a separate PR. I've also added the Gen-AI disclosure to the description, which I'd missed earlier. @potiuk this should cover the last open point from your review, could you take another look when you have a moment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
