potiuk commented on a change in pull request #7191: [AIRFLOW-4030] second attempt to add singularity to airflow URL: https://github.com/apache/airflow/pull/7191#discussion_r368562951
########## File path: tests/contrib/operators/test_singularity_operator.py ########## @@ -0,0 +1,180 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import unittest +import six + +from parameterized import parameterized +from spython.instance import Instance +from airflow import AirflowException + +try: + from airflow.contrib.operators.singularity_operator import SingularityOperator +except ImportError: + pass Review comment: Hey @vsoch. This is not strictly required, it's just helpful for you to get changes verified without waiting for Travis build. It's up to you if you want to run pre-commit only for commits or also for push. The latter has the benefit that it will run checks for all commits you are pushing together in case you have more than one commit. Here you have more infor: https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#pre-commit-hooks ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
