pavansai1997 commented on code in PR #76161:
URL: https://github.com/apache/airflow/pull/76161#discussion_r4434891007
##########
providers/google/src/airflow/providers/google/cloud/utils/external_token_supplier.py:
##########
@@ -172,6 +172,6 @@ def get_subject_key(self) -> str:
self.oidc_issuer_url
+ self.client_id
+ self.client_secret
- + ",".join(sorted(self.extra_params_kwargs))
+ + ",".join(f"{key}={value}" for key, value in
sorted(self.extra_params_kwargs.items()))
Review Comment:
Good catch, thanks! Fixed in 693f9a2096: the whole cache key is now
json.dumps([issuer_url, client_id,
client_secret, extra_params], sort_keys=True). The plain concatenation of
the issuer URL, client ID and
secret had the same issue ("ab" + "c" vs "a" + "bc"), so it's covered too.
Added a parametrized regression
test with your example and the client ID/secret case; both fail on the
previous code.
---
Drafted-by: Code Puppy (no human review before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
