uranusjr commented on PR #75538: URL: https://github.com/apache/airflow/pull/75538#issuecomment-6598251572
This PR contains a fix for the `test_lang_sdk_mixed_language` hang (#75421 and #74690). Can you add a short note on that in the PR description? I feel `isCancelled` should not quietly do nothing for a task that is not a `StoppableTask`. For such a task, it returns false and logs a warning, and `awaitCancellation` just sleeps, so the mistake shows up only in task logs. It should be an explicit opt-in by implementing `onKill`. Maybe `isCancelled` and `awaitCancellation` can throw `IllegalStateException`, or the polling API could move onto something only a stoppable task gets. `Cancellation.running` is a static that `Server` sets, `TaskRunner` reads, and `Context` captures at construction. Pass the `Cancellation` into `runTask` and `Context.from` instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
