hussein-awala commented on PR #70225: URL: https://github.com/apache/airflow/pull/70225#issuecomment-6600480743
> Small nit: The microsecond offset is an awkward way to say "exclude the triggering event". Why don't we add a named option such as `RunAfter(inclusive=False)`? I think it will read better, but it's fine to ship without it. > > Fantastic work for the sensor, thanks! Thanks! I agree that a named option would read better. I suggest keeping the explicit offset in this PR and considering `inclusive=False` separately. `resolve(context)` returns a timestamp without knowing whether it supplies `after` or `before`. An exclusive lower bound needs a positive adjustment. An exclusive upper bound needs a negative adjustment. We should define both cases, including their interaction with `offset`, before adding this option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
