amoghrajesh commented on code in PR #76053:
URL: https://github.com/apache/airflow/pull/76053#discussion_r4452668137
##########
providers/common/ai/provider.yaml:
##########
@@ -232,11 +232,27 @@ connection-types:
- 'null'
model_provider:
label: Default Model Provider
- description: "Provider for model names without a provider: prefix
(e.g. openai-chat)"
+ description: >
+ Provider for model names without a provider: prefix (e.g.
openai-chat).
+ Any provider the installed pydantic-ai recognizes works.
Review Comment:
```suggestion
Provider for model names without a provider: prefix (e.g.
openai-chat).
openai-chat uses Chat Completions, openai uses the Responses API.
Any provider the installed pydantic-ai recognizes works.
```
will this help text help?
##########
providers/common/ai/provider.yaml:
##########
@@ -232,11 +232,27 @@ connection-types:
- 'null'
model_provider:
label: Default Model Provider
- description: "Provider for model names without a provider: prefix
(e.g. openai-chat)"
+ description: >
+ Provider for model names without a provider: prefix (e.g.
openai-chat).
+ Any provider the installed pydantic-ai recognizes works.
schema:
type:
- string
- 'null'
+ # Suggestions on a free-text input, not an enum: an enum would
reject providers a newer
+ # pydantic-ai adds until the next release of this provider.
+ examples:
Review Comment:
I wonder if it will be useful (later, unrelated) to give an optional label
to examples, so each option can say what it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
