bbovenzi opened a new pull request, #76472: URL: https://github.com/apache/airflow/pull/76472
Formatting the UI package took ~12s with Prettier, a cost every contributor pays through the prek hook and again in CI. oxfmt does the same work in ~0.3s. The nine import groups from the Prettier sort-imports plugin carry over as oxfmt sortImports groups, so import order does not change. Keeping react in its own first group also keeps the license header above the first import; merged into the package group, @chakra-ui/react sorts ahead of react and is hoisted above the header. The seven source files that change are oxfmt's two formatting differences from Prettier: multi-line unions get a leading pipe, and one negated condition wraps inside the if parentheses. Codegen no longer passes --format prettier: openapi-gen is excluded from formatting and the generated files are byte-for-byte identical without it. | Command | Prettier | oxfmt | Speed-up | |---|---|---|---| | Whole package, binary (`prettier --check .` / `oxfmt --check .`) | 11.98 s ± 0.34 | 0.31 s ± 0.02 | ~38× | | Whole package via `pnpm -s …` | 12.62 s ± 0.30 | 0.91 s ± 0.07 | ~14× | --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [x] Yes (please specify the tool below) Claude Opus 5.5 <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
