jedcunningham commented on code in PR #76490:
URL: https://github.com/apache/airflow/pull/76490#discussion_r4474109851


##########
providers/fab/docs/changelog.rst:
##########
@@ -20,9 +20,12 @@
 Changelog
 ---------
 
+3.11.0
+......
+
 .. note::
-    Airflow 3.4.0 gives Dag bundles their own ``Dag Bundles`` resource, which 
``Op`` and ``Admin``
-    get by default. Upgrade this provider together with Airflow 3.4.0: older 
releases deny the Dag
+    Airflow 3.4.1 gives Dag bundles their own ``Dag Bundles`` resource, which 
``Op`` and ``Admin``
+    get by default. Upgrade this provider together with Airflow 3.4.1: older 
releases deny the Dag
     bundle pages and API to every role, including ``Admin``, while still 
showing the Browse menu
     entry. Custom roles need ``can read`` and ``menu access`` on ``Dag 
Bundles`` added by hand.

Review Comment:
   Agreed, though I'd fold it into the first sentence instead of adding an "On 
Airflow 3.4.1" line, since it applies from 3.4.1 on. `User` loses access too:
   
   ```rst
   .. note::
       Airflow 3.4.1 gives Dag bundles their own ``Dag Bundles`` resource, 
which only ``Op`` and
       ``Admin`` get by default, so ``Viewer`` and ``User`` lose the Dag bundle 
pages and API they
       reached through Dag read access. Upgrade this provider together with 
Airflow 3.4.1: older
       releases deny the Dag bundle pages and API to every role, including 
``Admin``, while still
       showing the Browse menu entry. Custom roles need ``can read`` and ``menu 
access`` on
       ``Dag Bundles`` added by hand.
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to