aoelvp94 commented on PR #73015: URL: https://github.com/apache/airflow/pull/73015#issuecomment-6653087189
> > > A high-level design question: Should archive mode be a separate class? > > > > > > Yeah, same question as I pointed out in [#73015 (review)](https://github.com/apache/airflow/pull/73015#pullrequestreview-5642408146). > > Agree with a separate class now. The archive path has grown its own state dir, marker, staging cleanup and download, so `S3DagBundle` would be two implementations behind a flag. Agreed — I'll split archive mode into a separate class (e.g. `S3ArchiveDagBundle`) instead of branching inside `S3DagBundle`. The archive path has its own marker, staging dir, and download path now, so a flag on the existing class is the wrong shape. I'll keep `S3DagBundle` as today's prefix path and move the archive behavior into the new class. Happy to use a thin `__new__` dispatch on `S3DagBundle` if we want one config entry point, or two explicit classpaths — whichever you prefer. I'll update GCS (#75566) and Azure (#75657) the same way once S3 lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
