kaxil commented on code in PR #76389:
URL: https://github.com/apache/airflow/pull/76389#discussion_r4467384870
##########
providers/common/ai/tests/unit/common/ai/utils/test_file_analysis.py:
##########
@@ -397,6 +397,27 @@ def test_csv_sample_rows_is_configurable(self, tmp_path):
assert "beta, 2" not in request.user_content
assert "gamma, 3" not in request.user_content
+ def test_csv_values_keep_their_quotes(self, tmp_path):
+ path = tmp_path / "people.csv"
+ path.write_text(
+ 'name,city,note\n"Smith, John","Vancouver, BC","said ""hi""\nthen
left"\n', encoding="utf-8"
Review Comment:
The one value here that needs quoting for something other than a comma has
both a quote and a line break, so taking either `"` or `\r\n` out of the set in
`_join_csv_values` still passes this test. Could this be a
`@pytest.mark.parametrize` with one value per trigger character? The line break
is half of the bug this fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
