fat-catTW commented on code in PR #76303: URL: https://github.com/apache/airflow/pull/76303#discussion_r4481419865
########## providers/amazon/src/airflow/providers/amazon/aws/executors/ecs/ecs_executor.py: ########## Review Comment: Thanks for clarifying the ECS queue behavior! I noticed a related difference. The task path passes `workload.ti.executor_config` to `execute_async`, but the callback path does not. For a task that has started, is it intentional for its routed callback to use the ECS executor’s defaults rather than the task’s `executor_config`? If the task uses a custom IAM role or network configuration, the callback might need the same settings to access its resources. Would it make sense to pass the task’s `executor_config` to its callback? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
